Delphi XE2 prerelease - shadow of bar series look strange

TeeChart VCL for Borland/CodeGear/Embarcadero RAD Studio, Delphi and C++ Builder.
Post Reply
marder
Advanced
Posts: 115
Joined: Thu May 29, 2008 12:00 am

Delphi XE2 prerelease - shadow of bar series look strange

Post by marder » Fri Nov 18, 2011 4:05 pm

Hi.

I am using the Delphi XE2 prerelease of TreeChart Pro V2011 and just wanted to report that the shadow of a bar series is looking quite strange with this version.

Before:
Image

Now:
Image

Will the shadow be corrected in the official release version?

best regards.

Yeray
Site Admin
Site Admin
Posts: 9612
Joined: Tue Dec 05, 2006 12:00 am
Location: Girona, Catalonia
Contact:

Re: Delphi XE2 prerelease - shadow of bar series look strange

Post by Yeray » Mon Nov 21, 2011 2:58 pm

Hello Marder,
marder wrote:I am using the Delphi XE2 prerelease of TreeChart Pro V2011 and just wanted to report that the shadow of a bar series is looking quite strange with this version.
You are right, it worked fine in v2011.03 but in v2011.04. I've added it to the defect list to be fixed asap (TV52015903).
PS: I assume you meant "pie series" where you said "bar series", according to the pictures. :P
Best Regards,
ImageYeray Alonso
Development & Support
Steema Software
Av. Montilivi 33, 17003 Girona, Catalonia (SP)
Image Image Image Image Image Image Please read our Bug Fixing Policy

marder
Advanced
Posts: 115
Joined: Thu May 29, 2008 12:00 am

Re: Delphi XE2 prerelease - shadow of bar series look strange

Post by marder » Mon Nov 21, 2011 4:23 pm

Hello Yeray.
I assume you meant "pie series"
Yes, I meant "pie" :wink:
I've added it to the defect list to be fixed asap
Could you please send me a fixed prerelease version when you have fixed this issue?
This would be great!

Best regards.

Narcís
Site Admin
Site Admin
Posts: 14730
Joined: Mon Jun 09, 2003 4:00 am
Location: Banyoles, Catalonia
Contact:

Re: Delphi XE2 prerelease - shadow of bar series look strange

Post by Narcís » Tue Nov 22, 2011 10:17 am

Hi marder,

I have logged your request in the issue description.
Best Regards,
Narcís Calvet / Development & Support
Steema Software
Avinguda Montilivi 33, 17003 Girona, Catalonia
Tel: 34 972 218 797
http://www.steema.com
Image Image Image Image Image Image
Instructions - How to post in this forum

marder
Advanced
Posts: 115
Joined: Thu May 29, 2008 12:00 am

Re: Delphi XE2 prerelease - shadow of bar series look strange

Post by marder » Thu Nov 08, 2012 8:48 am

Hi.

I wonder if there might be a fix for this issue in the official release of the upcoming V2012.07?

Best regards.

Narcís
Site Admin
Site Admin
Posts: 14730
Joined: Mon Jun 09, 2003 4:00 am
Location: Banyoles, Catalonia
Contact:

Re: Delphi XE2 prerelease - shadow of bar series look strange

Post by Narcís » Thu Nov 08, 2012 10:40 am

Hi marder,

Build 2012.07.121105, the version we published yesterday, is the official 2012.07 release.

The bug hasn't been fixed yet but we found where the problem is. Since you are a source code customer you may want to try implementing TTeeCanvas3D.SmoothShadow at TeCanvas.pas like this:

Code: Select all

procedure TTeeCanvas3D.SmoothShadow(Shadow:TTeeShadow; const Rect:TRect;
                             Ellipse:Boolean; RoundSize:Integer;
                             const P:Array of TPoint;
                             DonutPercent:Integer=0;
                             const Z:Double=0);
begin
  if Shadow.Smooth and (not Metafiling) {$IFNDEF FMX}and Assigned(FBitmap){$ENDIF} then
     Shadow.InternalDrawSmooth(Self,
                               CalcRect3D(Rect,Round(Z)),
                               Ellipse,RoundSize,P,DonutPercent)
  else
     inherited;
end;
That's similar to how it was implemented before introducing the bug. Now we will investigate the reason for this change and try to find a permanent fix for the issue.
Best Regards,
Narcís Calvet / Development & Support
Steema Software
Avinguda Montilivi 33, 17003 Girona, Catalonia
Tel: 34 972 218 797
http://www.steema.com
Image Image Image Image Image Image
Instructions - How to post in this forum

marder
Advanced
Posts: 115
Joined: Thu May 29, 2008 12:00 am

Re: Delphi XE2 prerelease - shadow of bar series look strange

Post by marder » Fri Nov 09, 2012 12:42 pm

Hi Narcis.

I downloaded final version V2012.07.
After installation I run "TeeRecompile.exe" and get the following error:

===============================================
TeeChart Pro
Compilation started: 09.11.12 13:39:22

RAD XE2.Win32 v16 Architect (RAD XE v9 Architect)
EXCEPTION:
Text: unit TeeChart not found in TeeChart.pas
--------------------------------------------


How can I get it to run?

Best regards.

Yeray
Site Admin
Site Admin
Posts: 9612
Joined: Tue Dec 05, 2006 12:00 am
Location: Girona, Catalonia
Contact:

Re: Delphi XE2 prerelease - shadow of bar series look strange

Post by Yeray » Fri Nov 09, 2012 12:45 pm

Hi Marder,

Please, remove the TeeChart.pas file and try it again.
Best Regards,
ImageYeray Alonso
Development & Support
Steema Software
Av. Montilivi 33, 17003 Girona, Catalonia (SP)
Image Image Image Image Image Image Please read our Bug Fixing Policy

marder
Advanced
Posts: 115
Joined: Thu May 29, 2008 12:00 am

Re: Delphi XE2 prerelease - shadow of bar series look strange

Post by marder » Fri Nov 09, 2012 2:51 pm

Hi Yeray,

Thank you that worked.
The shadow is again drawn as expected.

Please let me know when there is a new maintenance release including this fix.
Until then I will use the customization.

Best regards.

Narcís
Site Admin
Site Admin
Posts: 14730
Joined: Mon Jun 09, 2003 4:00 am
Location: Banyoles, Catalonia
Contact:

Re: Delphi XE2 prerelease - shadow of bar series look strange

Post by Narcís » Tue Nov 20, 2012 7:30 am

Hi marder,

As an update, TV52015903 has been fixed for the next maintenance release. The fix is at the TPieSeries.DrawAllValues method, in Series.pas:

Code: Select all

  if FShadow.Visible then
     FShadow.DrawEllipse(ParentChart.Canvas,
                         ParentChart.Canvas.CalcRect3D(CircleRect,tmpShadowZ),
                         tmpShadowZ,DonutPercent);
You should remove the change I suggested in TeCanvas.pas and change FShadow.DrawEllipse call as shown above.
Best Regards,
Narcís Calvet / Development & Support
Steema Software
Avinguda Montilivi 33, 17003 Girona, Catalonia
Tel: 34 972 218 797
http://www.steema.com
Image Image Image Image Image Image
Instructions - How to post in this forum

marder
Advanced
Posts: 115
Joined: Thu May 29, 2008 12:00 am

Re: Delphi XE2 prerelease - shadow of bar series look strange

Post by marder » Fri Nov 23, 2012 5:03 pm

Dear Narcis.

Thank you!
I will give this a try soon.

Best regards

marder
Advanced
Posts: 115
Joined: Thu May 29, 2008 12:00 am

Re: Delphi XE2 prerelease - shadow of bar series look strange

Post by marder » Mon Nov 26, 2012 3:09 pm

Dear Narcis.

The new fix seems to work correctly.
Thanks for your help!

Best regards.

Narcís
Site Admin
Site Admin
Posts: 14730
Joined: Mon Jun 09, 2003 4:00 am
Location: Banyoles, Catalonia
Contact:

Re: Delphi XE2 prerelease - shadow of bar series look strange

Post by Narcís » Mon Nov 26, 2012 3:20 pm

Dear Marder,

Thanks for your feedback, I'm glad to hear that.
Best Regards,
Narcís Calvet / Development & Support
Steema Software
Avinguda Montilivi 33, 17003 Girona, Catalonia
Tel: 34 972 218 797
http://www.steema.com
Image Image Image Image Image Image
Instructions - How to post in this forum

Post Reply